gazebosim / gz-physics

Abstract physics interface designed to support simulation and rapid development of robot applications.
https://gazebosim.org
Apache License 2.0
63 stars 38 forks source link

Support setting max contacts in dart's bullet collision detector #593

Open iche033 opened 5 months ago

iche033 commented 5 months ago

🎉 New feature

depends on #584

Summary

This PR extends dart's bullet collision detector to support the max contact collision pair feature.

This is a follow-up to #582 which added this feature for dart's ode collision detector.

Changes:

Test it

Updated test in simulation_features.c to test the max contact feature with dart's bullet collision detector

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 85.96491% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.54%. Comparing base (4fa59f2) to head (3ef0790). Report is 27 commits behind head on gz-physics6.

:exclamation: Current head 3ef0790 differs from pull request most recent head 48be582

Please upload reports for the commit 48be582 to get more accurate results.

Files Patch % Lines
dartsim/src/GzCollisionDetector.cc 87.23% 6 Missing :warning:
dartsim/src/WorldFeatures.cc 80.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## gz-physics6 #593 +/- ## =============================================== - Coverage 78.59% 78.54% -0.06% =============================================== Files 140 140 Lines 7654 7705 +51 =============================================== + Hits 6016 6052 +36 - Misses 1638 1653 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

azeey commented 4 weeks ago

@azeey to review