search

gazebosim / gz-physics

Abstract physics interface designed to support simulation and rapid development of robot applications.
https://gazebosim.org
Apache License 2.0
65 stars 40 forks source link

Merge 6 ➡️ 7 #594

Closed caguero closed 7 months ago

caguero commented 8 months ago

➡️ Forward port

Port gz-launch6 to gz-launch7

Branch comparison: https://github.com/gazebosim/gz-launch/compare/gz-launch7...gz-launch6

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

iche033 commented 8 months ago 
   [ 22%] Building CXX object test/common_test/CMakeFiles/COMMON_TEST_joint_mimic_features.dir/joint_mimic_features.cc.o
  /github/workspace/test/common_test/joint_mimic_features.cc:28:10: fatal error: TestLibLoader.hh: No such file or directory
     28 | #include "TestLibLoader.hh"

looks like the include path for TestLibLoader.hh has changed. It's now in a test subdir. So we'll need to update the new tests in gz-physics7 to use #include "test/TestLibLoader.hh"

codecov[bot] commented 8 months ago

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (5f73faf) 77.83% compared to head (cd290e0) 77.76%.

Files Patch % Lines
dartsim/src/GzOdeCollisionDetector.cc 82.85% 6 Missing :warning:
dartsim/src/WorldFeatures.cc 83.33% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## gz-physics7 #594 +/- ## =============================================== - Coverage 77.83% 77.76% -0.08% =============================================== Files 140 140 Lines 7772 7788 +16 =============================================== + Hits 6049 6056 +7 - Misses 1723 1732 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

scpeters commented 8 months ago

https://github.com/gazebosim/gz-physics/pull/594/commits/10165398348111c0ac55e1af592c06fade1980a7 has been reverted, so let's sync with gz-physics6 again