gazebosim / gz-physics

Abstract physics interface designed to support simulation and rapid development of robot applications.
https://gazebosim.org
Apache License 2.0
63 stars 38 forks source link

`DetachableJointTest.CorrectAttachmentPoints` dartsim test fails on Homebrew CI #612

Closed iche033 closed 2 months ago

iche033 commented 3 months ago

The DetachableJointTest.CorrectAttachmentPoints dartsim test started failing. This is likely caused by the new ODE 0.16.5 bottle, see https://github.com/gazebosim/gz-physics/pull/611#issuecomment-2027523960

Environment

Description

Output

Test failure output from homebrew jenkins:

59: Testing plugin: gz::physics::dartsim::Plugin
59: /Users/jenkins/jenkins-agent/workspace/gz_physics-ci-pr_any-homebrew-amd64/gz-physics/test/common_test/detachable_joint.cc:190: Failure
59: The difference between 0.15 and frameDataC1L1.pose.translation().z() is 0.10148802840906343, which exceeds 1e-2, where
59: 0.15 evaluates to 0.14999999999999999,
59: frameDataC1L1.pose.translation().z() evaluates to 0.048511971590936565, and
59: 1e-2 evaluates to 0.01.
scpeters commented 3 months ago

potential fix in https://github.com/Homebrew/homebrew-core/pull/167521

scpeters commented 3 months ago

Actual fix in https://github.com/Homebrew/homebrew-core/pull/167721, reverting the workaround in https://github.com/gazebosim/gz-physics/pull/615