Closed Fixit-Davide closed 2 weeks ago
CI picked up a few cpplint warnings:
/github/workspace/bullet-featherstone/src/JointFeatures.cc:87: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
/github/workspace/bullet-featherstone/src/JointFeatures.cc:90: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/bullet-featherstone/src/JointFeatures.cc:95: Lines should be <= 80 characters long [whitespace/line_length] [2]
Attention: Patch coverage is 0%
with 24 lines
in your changes missing coverage. Please review.
Project coverage is 78.67%. Comparing base (
92e02c3
) to head (9aee181
). Report is 21 commits behind head on gz-physics7.:exclamation: Current head 9aee181 differs from pull request most recent head beaacc7
Please upload reports for the commit beaacc7 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
bullet-featherstone/src/JointFeatures.cc | 0.00% | 24 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Any changes needed in order to merge? I can write the test for https://github.com/gazebosim/gz-sim/pull/2369 afterward.
I'll go ahead and merge this first
π New feature
Related to the PR: https://github.com/gazebosim/gz-sim/pull/2369
Partially solves: https://github.com/gazebosim/gz-sim/issues/883
Summary
Allow the
GetJointForce()
method in bullet-featherston to return the joint feedback Force and not 0. This allow thejoint_state_publisher
to publish data containing the force field.Test it
gz sim --physics-engine gz-physics-bullet-featherstone-plugin lift_drag.sdf
simulation.gz topic -t "/model/lift_drag_demo_model/joint/rod_1_joint/cmd_force" -m gz.msgs.Double -p "data: 0.8"
).gz topic -e -t /world/lift_drag/model/lift_drag_demo_model/joint_state
Checklist
codecheck
passed (See contributing)