gazebosim / gz-physics

Abstract physics interface designed to support simulation and rapid development of robot applications.
https://gazebosim.org
Apache License 2.0
62 stars 38 forks source link

[featherstone] Publish JointFeedback forces. #628

Closed Fixit-Davide closed 2 weeks ago

Fixit-Davide commented 2 months ago

πŸŽ‰ New feature

Related to the PR: https://github.com/gazebosim/gz-sim/pull/2369

Partially solves: https://github.com/gazebosim/gz-sim/issues/883

Summary

Allow the GetJointForce() method in bullet-featherston to return the joint feedback Force and not 0. This allow the joint_state_publisher to publish data containing the force field.

Test it

iche033 commented 2 months ago

CI picked up a few cpplint warnings:

  /github/workspace/bullet-featherstone/src/JointFeatures.cc:87:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
  /github/workspace/bullet-featherstone/src/JointFeatures.cc:90:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
  /github/workspace/bullet-featherstone/src/JointFeatures.cc:95:  Lines should be <= 80 characters long  [whitespace/line_length] [2]
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 78.67%. Comparing base (92e02c3) to head (9aee181). Report is 21 commits behind head on gz-physics7.

:exclamation: Current head 9aee181 differs from pull request most recent head beaacc7

Please upload reports for the commit beaacc7 to get more accurate results.

Files Patch % Lines
bullet-featherstone/src/JointFeatures.cc 0.00% 24 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## gz-physics7 #628 +/- ## =============================================== + Coverage 78.32% 78.67% +0.34% =============================================== Files 140 140 Lines 8069 8158 +89 =============================================== + Hits 6320 6418 +98 + Misses 1749 1740 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Fixit-Davide commented 2 weeks ago

Any changes needed in order to merge? I can write the test for https://github.com/gazebosim/gz-sim/pull/2369 afterward.

iche033 commented 2 weeks ago

I'll go ahead and merge this first