Closed iche033 closed 1 month ago
Attention: Patch coverage is 92.30769%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 79.06%. Comparing base (
92e02c3
) to head (4f35c1e
). Report is 17 commits behind head on gz-physics7.:exclamation: Current head 4f35c1e differs from pull request most recent head 84054fa
Please upload reports for the commit 84054fa to get more accurate results.
Files | Patch % | Lines |
---|---|---|
bullet-featherstone/src/KinematicsFeatures.cc | 92.30% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for adding the test. I'm tracking all frame data issues in https://github.com/gazebosim/gz-physics/issues/648
I think there's still an issue with model FrameData calculation, but I think it would be best to address in a separate PR.
Follow-up PR: #649
🦟 Bug fix
hide whitespace changes for better diff: https://github.com/gazebosim/gz-physics/pull/647/files?w=1
Summary
Currently if a collision has a pose offset, the bullet-featherstone plugin return an incorrect axis aligned bounding box for the link containing the collision. This is found to be caused by incorrect frame data pose computed for collisions - It currently ignores the collision pose offset.
This PR makes a few changes to
KinematicsFeatures::FrameDataRelativeToWorld
in bullet-featherstone plugin:The link_features's bounding box test was previously skipped for bullet-featherstone plugin. This PR enables this test for bullet-featherstone by requiring only a minimal set of features needed to run the test.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.