gazebosim / gz-physics

Abstract physics interface designed to support simulation and rapid development of robot applications.
https://gazebosim.org
Apache License 2.0
62 stars 38 forks source link

bullet-featherstone: Fix joint frame data pose #650

Open iche033 opened 1 month ago

iche033 commented 1 month ago

🦟 Bug fix

Related issue https://github.com/gazebosim/gz-physics/issues/648

Summary

Fix joint frame data pose calculation. Re-enabled a check in JointFrameSemantics test for bullet-featherstone and the test should now pass.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (bullet_kinematic_feature@081c672). Learn more about missing BASE report.

Files Patch % Lines
bullet-featherstone/src/KinematicsFeatures.cc 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## bullet_kinematic_feature #650 +/- ## =========================================================== Coverage ? 79.30% =========================================================== Files ? 140 Lines ? 8262 Branches ? 0 =========================================================== Hits ? 6552 Misses ? 1710 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.