Enabled tests in joint_features related to testing joint limits using velocity control. There are still issues with force control so those tests remain disabled in bullet-featherstone
Note I added collisions to the simple_joint_test in test.world (used by various joint limit tests) because bullet-featherstone requires a link to have collisions otherwise the joints do not move.
Here's a joint_limits.sdf world that consists of a simple model with JointPositionController
Before: joint limits not enforced so joint rotates at a high speed
After: joint limits enforced
Checklist
[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.
🎉 New feature
Closes #
Summary
Updated
SetJointVelocityCommand
to enforce joint limits byAdded the following features:
Test it
Enabled tests in joint_features related to testing joint limits using velocity control. There are still issues with force control so those tests remain disabled in bullet-featherstone
Note I added collisions to the
simple_joint_test
intest.world
(used by various joint limit tests) because bullet-featherstone requires a link to have collisions otherwise the joints do not move.Here's a joint_limits.sdf world that consists of a simple model with JointPositionController
Before: joint limits not enforced so joint rotates at a high speed
After: joint limits enforced
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.