gazebosim / gz-physics

Abstract physics interface designed to support simulation and rapid development of robot applications.
https://gazebosim.org
Apache License 2.0
62 stars 38 forks source link

gz-physics fails to compile against dartsim 6.14.1 #660

Closed scpeters closed 4 days ago

scpeters commented 6 days ago

Environment

Build Status https://build.osrfoundation.org/job/gz_physics-ci-gz-physics7-homebrew-amd64/62/

Description

Steps to reproduce

  1. Install latest version (6.14.1) of dartsim on macOS from homebrew
  2. Build gz-physics7
  3. Observer compiler error

Output

/tmp/gz-physics7-20240628-32522-zc6n0e/gz-physics-7.3.0/dartsim/src/Base.hh:44:5: error: invalid token at start of a preprocessor expression
#if DART_VERSION_AT_LEAST(6, 13, 0)
    ^
/usr/local/include/dart/config.hpp:38:3: note: expanded from macro 'DART_VERSION_AT_LEAST'
  DART_VERSION_GE(x, y, z)
  ^
/usr/local/include/dart/config.hpp:19:4: note: expanded from macro 'DART_VERSION_GE'
  (DART_MAJOR_VERSION > x                                                      \
   ^
/usr/local/include/dart/config.hpp:5:28: note: expanded from macro 'DART_MAJOR_VERSION'
#define DART_MAJOR_VERSION @DART_MAJOR_VERSION @
                           ^

There is a potential fix in https://github.com/dartsim/dart/pull/1820

scpeters commented 4 days ago

gz-physics7 compiles again now that dartsim 6.14.2 is released