gazebosim / gz-rendering

C++ library designed to provide an abstraction for different rendering engines. It offers unified APIs for creating 3D graphics applications.
https://gazebosim.org
Apache License 2.0
56 stars 51 forks source link

Fix Windows github action workflow #1080

Closed iche033 closed 1 month ago

iche033 commented 1 month ago

🦟 Bug fix

Fix windows github actions workflow. It started failing recently on gz-rendering9and main, with the error:

usage: colcon [-h] [--log-base LOG_BASE] [--log-level LOG_LEVEL]
              {build,extension-points,extensions,graph,info,list,metadata,test,test-result,version-check}
              ...
colcon: error: unrecognized arguments: -A x64 -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF

Not sure what has changed but the fixed by putting double quotes around each cmake arg passed to colcon build

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.