Suppress "missing Optix" cmake warning

gazebosim / gz-rendering

C++ library designed to provide an abstraction for different rendering engines. It offers unified APIs for creating 3D graphics applications.

https://gazebosim.org

Apache License 2.0

50 stars 48 forks source link

Open chapulina opened 3 years ago

chapulina commented 3 years ago

Expected behavior: Our CI should be green, warning-free. But since https://github.com/ignitionrobotics/ign-cmake/pull/159 we get warnings for missing dependencies. Since Optix is optional and we don't plan on running CI for it, I think we should disable these warnings.
Actual behavior: There are CMake warnings

Build ign-rendering without Optix installed.

-- Cannot build component [optix] - Missing: OptiX

j-rivero commented 3 years ago

Quick look at it, if I'm not wrong the logic goes:

ign_find_package won't find optix so it will call the ign_build_warnings method no matter what other options are.
ign_configure_build will take the warnings and display them unconditionally as cmake WARNINGS since https://github.com/ignitionrobotics/ign-cmake/pull/159

If that is correct, we probably want to add an option to ign_find_package that can indicate that missing support is not a warning.

chapulina commented 3 years ago

option to ign_find_package that can indicate that missing support is not a warning

I'd expect that calling find_package with QUIET wouldn't print a warning, so maybe we can do the same for ign_find_package?

chapulina commented 3 years ago

@j-rivero , I have a suggestion on the PRs above :point_up: