search

gazebosim / gz-rendering

C++ library designed to provide an abstraction for different rendering engines. It offers unified APIs for creating 3D graphics applications.
https://gazebosim.org
Apache License 2.0
50 stars 48 forks source link

Dummy ignition::rendering::BaseCamera::SaveFrame #93

Open agayev169 opened 4 years ago

agayev169 commented 4 years ago

ignition::rendering::BaseCamera::SaveFrame is a dummy function. Please, either mention this in the documentation or write the function.

chapulina commented 4 years ago

All functions on BaseCamera are virtual functions that can be reimplemented by each rendering engine.

So I imagine what you're asking for is for that function to be implemented on either Ogre or Ogre2, right?

agayev169 commented 4 years ago

I use Ogre2 in my project, that is right. And as far as I understand, I cannot save an image from the camera itself. The way I did it is by capturing the image and then saving it with the help of ign-common.

I think it may be better to implement the function or override it for Ogre2Camera. Otherwise, a lot of users will use the function without understanding why it does not do anything (which happened to me).

chapulina commented 4 years ago

Understood. I don't think we'll have time to work on this anytime in the future, but pull requests are welcome :wink: