gazebosim / gz-sim

Open source robotics simulator. The latest version of Gazebo.

https://gazebosim.org

Apache License 2.0

621 stars 251 forks source link

fixed thruster.cc undefined behavior #2316

Closed GauravKumar9920 closed 3 months ago

GauravKumar9920 commented 4 months ago

🦟 Bug fix

Fixes #2291

Summary

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

GauravKumar9920 commented 3 months ago

I'm sorry, My bad. I will look into the whole code once again and make changes and make sure I'm not missing out on any bugs or anything.

arjo129 commented 3 months ago

This is looking a lot better!

Do you mind signing off via DCO. Instructions are here: https://github.com/gazebosim/gz-sim/pull/2316/checks?check_run_id=22827807927

GauravKumar9920 commented 3 months ago

Lol. This happens to all of us. If your git-fu is not strong enough I recommend closeing this PR and opening a new one in a new branch of main. Just copy the new test/thruster.cc over.

Thanks @arjo129 I was really unsure of what has happened, I wasn't able to find a reliable solution for it online. I will open a new pr : )