Closed Bogdanov-am closed 4 months ago
Attention: Patch coverage is 50.00000%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 65.95%. Comparing base (
633ce72
) to head (89a9a54
).:exclamation: Current head 89a9a54 differs from pull request most recent head 50a9b4e. Consider uploading reports for the commit 50a9b4e to get more accurate results
Files | Patch % | Lines |
---|---|---|
...rc/systems/odometry_publisher/OdometryPublisher.cc | 50.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@azeey Any idea when this would be released?
We'll shoot for making a release this week.
Awesome. Thanks for the heads up :+1:
🦟 Bug fix
Until SystemManager has the ability to unload system plugins, plugins require an explicit check of the validity of the entities used in the Update methods. Such a check was missing in OdometryPublisher, which led to non-critical but annoying errors in the console.
P.S. It's my first PR to open source project, sorry if i missing something