gazebosim / gz-sim

Open source robotics simulator. The latest version of Gazebo.
https://gazebosim.org
Apache License 2.0
621 stars 251 forks source link

Fix wget in maritime tutorials #2330

Closed caguero closed 3 months ago

caguero commented 4 months ago

🦟 Bug fix

Fixes #2329

Summary

There were some problems with the wget commands. This patch should fix it.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.97%. Comparing base (2ca64d0) to head (2d27c3f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## gz-sim8 #2330 +/- ## =========================================== + Coverage 65.95% 65.97% +0.01% =========================================== Files 327 327 Lines 31347 31347 =========================================== + Hits 20676 20681 +5 + Misses 10671 10666 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

caguero commented 4 months ago

Changes work for me now. However, it seems like we are also commiting a zip file and then removing the old files? Shouldnt we download just the zip or use a git commit hash in the url?

@arjo129 , could you clarify that?

arjo129 commented 3 months ago

Yeah mabel is right. I think I got confused by the deletion of some of the files.