Closed sauk2 closed 2 months ago
@azeey I noticed this while working on issue #2289. I have since found that adding SceneBroadcaster
plugin to the SDF resolves this issue.
If you could confirm this issue is valid, I can raise a fix PR for the same.
Hi @sauk2 , those files are meant to be used for integration tests. They don't need the SceneBroadcaster
because the tests don't need the GUI. Adding it will unnecessarily increase test time. Most of the SDFormat files there intentionally don't have the SceenBroadcaster
or other systems that are normally essential. Instead of your fix in #2346, what we need is a README in the test/worlds
directory to tell users not to use these files, but instead refer to the examples
directory.
Hi @sauk2 , those files are meant to be used for integration tests. They don't need the
SceneBroadcaster
because the tests don't need the GUI. Adding it will unnecessarily increase test time. Most of the SDFormat files there intentionally don't have theSceenBroadcaster
or other systems that are normally essential. Instead of your fix in #2346, what we need is a README in thetest/worlds
directory to tell users not to use these files, but instead refer to theexamples
directory.
I was not aware of that. Thanks for the clarification.
To my knowledge, there is no example usage of DopplerVelocityLogSystem
present in the examples
directory. Do you think it would be a good idea to provide one?
Yes @sauk2. Rather than adding it to the integration tests (which dont need visuals) create a new doppler velocity log example file.
Yes @sauk2. Rather than adding it to the integration tests (which dont need visuals) create a new doppler velocity log example file.
@arjo129 Understood. Will go ahead with that.
Should I add that README too as a part of that PR? If yes, then is there any additional information it should contain other than what is mentioned in the following comment?
Hi @sauk2 , those files are meant to be used for integration tests. They don't need the
SceneBroadcaster
because the tests don't need the GUI. Adding it will unnecessarily increase test time. Most of the SDFormat files there intentionally don't have theSceenBroadcaster
or other systems that are normally essential. Instead of your fix in #2346, what we need is a README in thetest/worlds
directory to tell users not to use these files, but instead refer to theexamples
directory.
Yes thatd be great!!
Environment
Description
The test worlds for
DopplerVelocityLogSystem
plugin show a blank screen after launching. Specifically these files:test/worlds/bottomless_pit.sdf
test/worlds/flat_seabed.sdf
test/worlds/underwater_currents.sdf
Steps to reproduce
The gz command is run with verbosity 2
Output
This is the screen that is seen. No change occurs after this.
Following is the generated log