gazebosim / gz-sim

Open source robotics simulator. The latest version of Gazebo.
https://gazebosim.org
Apache License 2.0
686 stars 263 forks source link

Fix TriggeredPublisher test #2354

Closed azeey closed 5 months ago

azeey commented 6 months ago

🦟 Bug fix

Summary

Fixes TriggeredPublisherTest.InputMessagesTriggerServices test which has been failing since https://github.com/gazebosim/gz-transport/pull/470. The issue is that service requests from the previous test, TriggeredPublisherTest.InvalidServiceName, are received in this test and cause a mismatch on the expected number of received requests. The (hopefully) temporary solution is to sleep a small amount of time right after advertising the service so that the extraneous service requests are received and discarded before we start the main body of the test.

Also see https://github.com/gazebosim/gz-transport/issues/491

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

azeey commented 6 months ago

@osrf-jenkins run tests please

azeey commented 6 months ago

@j-rivero The Ubuntu build keeps on using prerelease even though I've reverted gz-sim to use the stable repo in https://github.com/gazebo-tooling/gzdev/pull/85. Shouldn't gzdev delete /etc/apt/sources.list.d/_gzdev_*.list and create new ones?

azeey commented 5 months ago

I've made another prerelease of gz-transport13 to workaround the caching issue.

azeey commented 5 months ago

The TriggeredPublisher test is now passing. The other failures on Github Action and windows seem unrelated.

Blast545 commented 5 months ago

:farmer: @azeey This one made it back into CI, see:

https://build.osrfoundation.org/job/gz_sim-ci-main-jammy-amd64/65/, https://build.osrfoundation.org/job/gz_sim-ci-main-jammy-amd64/65/testReport/junit/(root)/TriggeredPublisherTest/InputMessagesTriggerServices/

Took some time to check the PRs on gz-transport and gz-sim merged in the last week, but I don't see any reason for it to appear again.