search

gazebosim / gz-sim

Open source robotics simulator. The latest version of Gazebo.
https://gazebosim.org
Apache License 2.0
621 stars 251 forks source link

Merge 8 -> main #2378

Closed iche033 closed 2 months ago

iche033 commented 2 months ago

➡️ Forward port

Port gz-sim8 to main

Branch comparison: https://github.com/gazebosim/gz-sim/compare/main...gz-sim8

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 65.95%. Comparing base (ae75c25) to head (098085b). Report is 74 commits behind head on main.

Files Patch % Lines
src/ServerConfig.cc 57.14% 3 Missing :warning:
src/Server.cc 83.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2378 +/- ## ========================================== + Coverage 65.66% 65.95% +0.28% ========================================== Files 324 327 +3 Lines 30938 31319 +381 ========================================== + Hits 20315 20655 +340 - Misses 10623 10664 +41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

azeey commented 2 months ago

I think the warning on Jammy is an existing issue and should be fixed in a follow up PR. This is good to merge.

Blast545 commented 2 months ago

:farmer: @azeey The warning on jammy should be fixed after https://github.com/gazebosim/gz-sim/pull/2388 gets forward ported, should I open a PR for that one or wait until there's a new round of forward ports to main?

PTAL https://github.com/gazebosim/gz-sim/pull/2395