gazebosim / gz-sim

Open source robotics simulator. The latest version of Gazebo.
https://gazebosim.org
Apache License 2.0
621 stars 251 forks source link

Improve standalone examples (and a bit of example CMake) #2387

Open Ryanf55 opened 2 months ago

Ryanf55 commented 2 months ago

Docs

Summary

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

azeey commented 1 month ago

Can you fix the conflict on examples/standalone/gtest_setup/CMakeLists.txt?

Blast545 commented 1 month ago

:farmer: @Ryanf55 I was taking a look to this to fix our CI, it's pretty close to be mergeable, let us know if you need help with the remaining conflicts :rocket:

Ryanf55 commented 1 month ago

Looks like gtest can't be found in CI. Should I be making changes to the local CI, or is this managed elsewhere? https://build.osrfoundation.org/job/gz_sim-ci-pr_any-jammy-amd64/610/cmake/new/

azeey commented 1 month ago

Looks like gtest can't be found in CI. Should I be making changes to the local CI, or is this managed elsewhere? https://build.osrfoundation.org/job/gz_sim-ci-pr_any-jammy-amd64/610/cmake/new/

I think it's best to revert your changes. I don't think we're prepared to change our CI for this.