gazebosim / gz-sim

Open source robotics simulator. The latest version of Gazebo.
https://gazebosim.org
Apache License 2.0
621 stars 251 forks source link

Fix CMake warnings in Noble #2397

Closed Blast545 closed 1 month ago

Blast545 commented 1 month ago

🦟 Bug fix

Fixes CMake warnings in Noble

Summary

Removing the deprecated Dart (Testing tool) include and explicitly setting the timestamp option when fetch declaring googleTest in a specific example.

Reference build: https://build.osrfoundation.org/job/gz_sim-ci-gz-sim8-noble-amd64/18/

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

azeey commented 1 month ago

https://github.com/gazebosim/gz-sim/pull/2387 is close to being merged and it has changes to examples/standalone/gtest_setup/CMakeLists.txt. Should we wait for that?

Blast545 commented 1 month ago

@azeey I think if that one gets merged, this PR won't be needed, as the complete FetchContent logic is removed.

I didn't saw that one, if that's close to be merged I'll just put this one as a draft and close/continue if needed be.

Blast545 commented 1 month ago

@ros-pull-request-builder retest this please