gazebosim / gz-sim

Open source robotics simulator. The latest version of Gazebo.
https://gazebosim.org
Apache License 2.0
618 stars 251 forks source link

Enable 24.04 CI, require cmake 3.22.1 #2420

Closed scpeters closed 1 month ago

scpeters commented 1 month ago

🎉 New feature

Part of https://github.com/gazebosim/gz-cmake/issues/350.

Summary

This adds a GitHub workflow using Noble and increases our minimum required cmake version to 3.22.1 since we are already requiring that in gz-cmake4. It also removes some old code to support older versions of cmake.

Test it

Look at the 24.04 CI results.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

scpeters commented 1 month ago

there are some cmake warnings that should be resolved

scpeters commented 1 month ago

there are some cmake warnings that should be resolved

actually these cmake warnings are preexisting on main, but I'll see if I can fix them here anyway

scpeters commented 1 month ago

there are some cmake warnings that should be resolved

actually these cmake warnings are preexisting on main, but I'll see if I can fix them here anyway

fix from https://github.com/gazebosim/gz-sim/pull/2397 is being merged forward in https://github.com/gazebosim/gz-sim/pull/2422

scpeters commented 1 month ago

CI is relatively happy now, just a flaky test failure on windows