gazebosim / gz-sim

Open source robotics simulator. The latest version of Gazebo.
https://gazebosim.org
Apache License 2.0
619 stars 251 forks source link

Do not update sensors if it a triggered sensor #2443

Closed iche033 closed 2 weeks ago

iche033 commented 2 weeks ago

🦟 Bug fix

Depends on https://github.com/gazebosim/gz-sensors/pull/441

Summary

Currently the logic for checking active sensors ignores the triggered property of a camera. So as the result, when you subscribe to any triggered sensors, they become "active" (added to the activeSensors list) and they perform unnecessary prerender updates even when they don't have pending triggers. This PR adds a check for the triggered property of the sensor to filter them out when checking for active sensors.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

iche033 commented 2 weeks ago

@osrf-jenkins run tests please

iche033 commented 2 weeks ago

The ModelCommandAPI unit test failure caught by the gz_sim-ci-pr_any-jammy-amd64 build should be fixed in https://github.com/gazebosim/gz-sim/pull/2444