gazebosim / gz-sim

Open source robotics simulator. The latest version of Gazebo.
https://gazebosim.org
Apache License 2.0
728 stars 272 forks source link

Fix log playback GUI display #2611

Closed azeey closed 2 months ago

azeey commented 2 months ago

🦟 Bug fix

Fixes https://github.com/gazebosim/gazebo_test_cases/issues/1640

Alternative to: https://github.com/gazebosim/gz-sim/pull/2590

Summary

Loading the logging playback plugin before SceneBroadcaster prevents playback from being displayed on the GUI. This order was changed in #2452 which caused the regression.

I haven't had time to delve into why the order matters, but it can easily be verified by running test/worlds/log_playback.sdf with <playback_path> set to the log directory. If the plugin comes before SceneBroadcaster, the playback is not displayed on the GUI.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

avanmalleghem commented 2 months ago

When will it be merged so that we can finish some tutorials ?

arjo129 commented 2 months ago

Regression test added in https://github.com/gazebosim/gz-sim/pull/2619

azeey commented 2 months ago

The CI failure seems to be flaky and is also present in the target branch https://build.osrfoundation.org/view/gz-ionic/job/gz_sim-ci-gz-sim9-noble-amd64/test_results_analyzer/