Closed mergify[bot] closed 2 days ago
Cherry-pick of 1a881310cfe2e1c97bdb7d606cf973eebc17a6c1 has failed:
On branch mergify/bp/ign-gazebo6/pr-2596
Your branch is up to date with 'origin/ign-gazebo6'.
You are currently cherry-picking commit 1a881310c.
(fix conflicts and run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Unmerged paths:
(use "git add <file>..." to mark resolution)
both modified: include/gz/sim/components/Model.hh
no changes added to commit (use "git add" and/or "git commit -a")
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
π¦ Bug fix
Fixes #
Summary
I was investigating https://github.com/gazebosim/gazebo_test_cases/issues/1576 , in my investigation it came to my notice that
sdf::Root
takes a long time to be constructed. While I am submitting changes upstream to reduce the impact of the creation ofsdf::Root
, in the event that we don't serialize a model, I'm proposing we just send an empty string accross. This should minimize both network traffic and make load times more manageable.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.πΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈπΈ
This is an automatic backport of pull request #2596 done by Mergify.