Closed mboisson closed 3 years ago
chapulina
commented
3 years ago I have protobuf/3.12.3 and cmake/3.16.5
I think your Protobuf version is too new. What OS are you in?
Would you mind using the issue template next time and filling the relevant info? Thanks! :v:
Cross-referencing this related PR: https://github.com/ignitionrobotics/ign-gazebo/pull/715
traversaro
commented
3 years ago Probably you need to define to ON the protobuf_MODULE_COMPATIBLE CMake option in ign-gazebo. The motivation is a bit intricate, but you can find some details in the PR linked by @chapulina : https://github.com/ignitionrobotics/ign-gazebo/pull/715 .
mboisson
commented
3 years ago My apologies. I did not use the template because none of it seemed relevant, but still, here it is : OS Version: Gentoo on top of CentOS, using Lmod and EasyBuild to provide many pieces of the software. This is for a supercomputer. Source version: (version provided above) It is not a rendering error, but rather a compilation one.
What version of protobuf is needed ?
The PROTOBUF_GENERATE_CPP function does exist in our installation of protobuf. It seems that it is not about the function not existing, but rather that it is not being found:
rep -ri PROTOBUF_GENERATE_CPP $EBROOTPROTOBUF
/cvmfs/soft.computecanada.ca/easybuild/software/2020/avx2/Core/protobuf/3.12.3/lib64/cmake/protobuf/protobuf-module.cmake:function(PROTOBUF_GENERATE_CPP SRCS HDRS)
/cvmfs/soft.computecanada.ca/easybuild/software/2020/avx2/Core/protobuf/3.12.3/lib64/cmake/protobuf/protobuf-module.cmake: cmake_parse_arguments(protobuf_generate_cpp "" "EXPORT_MACRO" "" ${ARGN})
/cvmfs/soft.computecanada.ca/easybuild/software/2020/avx2/Core/protobuf/3.12.3/lib64/cmake/protobuf/protobuf-module.cmake: set(_proto_files "${protobuf_generate_cpp_UNPARSED_ARGUMENTS}")
/cvmfs/soft.computecanada.ca/easybuild/software/2020/avx2/Core/protobuf/3.12.3/lib64/cmake/protobuf/protobuf-module.cmake: message(SEND_ERROR "Error: PROTOBUF_GENERATE_CPP() called without any proto files")
/cvmfs/soft.computecanada.ca/easybuild/software/2020/avx2/Core/protobuf/3.12.3/lib64/cmake/protobuf/protobuf-module.cmake: if(PROTOBUF_GENERATE_CPP_APPEND_PATH)
/cvmfs/soft.computecanada.ca/easybuild/software/2020/avx2/Core/protobuf/3.12.3/lib64/cmake/protobuf/protobuf-module.cmake: protobuf_generate(${_append_arg} LANGUAGE cpp EXPORT_MACRO ${protobuf_generate_cpp_EXPORT_MACRO} OUT_VAR _outvar ${_import_arg} PROTOS ${_proto_files})
/cvmfs/soft.computecanada.ca/easybuild/software/2020/avx2/Core/protobuf/3.12.3/lib64/cmake/protobuf/protobuf-module.cmake: if(PROTOBUF_GENERATE_CPP_APPEND_PATH)
/cvmfs/soft.computecanada.ca/easybuild/software/2020/avx2/Core/protobuf/3.12.3/lib64/cmake/protobuf/protobuf-module.cmake:# By default have PROTOBUF_GENERATE_CPP macro pass -I to protoc
/cvmfs/soft.computecanada.ca/easybuild/software/2020/avx2/Core/protobuf/3.12.3/lib64/cmake/protobuf/protobuf-module.cmake:if(NOT DEFINED PROTOBUF_GENERATE_CPP_APPEND_PATH)
/cvmfs/soft.computecanada.ca/easybuild/software/2020/avx2/Core/protobuf/3.12.3/lib64/cmake/protobuf/protobuf-module.cmake: set(PROTOBUF_GENERATE_CPP_APPEND_PATH TRUE)I already tried patching the relevant (I think) CMakeLists.txt files with this patch:
diff -ru ign-gazebo-ignition-gazebo3_3.8.0.orig/CMakeLists.txt ign-gazebo-ignition-gazebo3_3.8.0/CMakeLists.txt
--- ign-gazebo-ignition-gazebo3_3.8.0.orig/CMakeLists.txt 2021-08-03 16:04:54.039525404 +0000
+++ ign-gazebo-ignition-gazebo3_3.8.0/CMakeLists.txt 2021-08-03 16:05:36.884825979 +0000
@@ -131,6 +131,7 @@
#--------------------------------------
# Find protobuf
set(REQ_PROTOBUF_VER 3)
+set(protobuf_MODULE_COMPATIBLE ON CACHE BOOL "")
ign_find_package(IgnProtobuf
VERSION ${REQ_PROTOBUF_VER}
REQUIRED
diff -ru ign-gazebo-ignition-gazebo3_3.8.0.orig/src/msgs/CMakeLists.txt ign-gazebo-ignition-gazebo3_3.8.0/src/msgs/CMakeLists.txt
--- ign-gazebo-ignition-gazebo3_3.8.0.orig/src/msgs/CMakeLists.txt 2021-08-03 16:04:54.052525495 +0000
+++ ign-gazebo-ignition-gazebo3_3.8.0/src/msgs/CMakeLists.txt 2021-08-03 16:50:21.020668379 +0000
@@ -1,3 +1,4 @@
+set(protobuf_MODULE_COMPATIBLE ON CACHE BOOL "")
PROTOBUF_GENERATE_CPP(PROTO_PRIVATE_SRC PROTO_PRIVATE_HEADERS
peer_info.proto
peer_control.protoI already tried patching the relevant (I think)
CMakeLists.txtfiles with this patch:
I am afraid that patch will not work if protobuf_MODULE_COMPATIBLE CMake cache variable is already defined by a previous (transitive) call to find_package(Protobuf CONFIG) . I suggest to move the patch earlier in the CMakeLists.txt before any find_package call, or just pass it as a CMake command line option.
traversaro
commented
3 years ago In a sense, probably we just need to move the line https://github.com/ignitionrobotics/ign-gazebo/blob/ign-gazebo5/CMakeLists.txt#L140 before any call to find_package (or at least any call that transitive search for Protobuf).
mboisson
commented
3 years ago Adding to the cmake command line options worked, so I guess I can workaround it without the patch.
Now I hit another compilation bug, which seems related to ignition-physics2:
26511 CMake Error in src/systems/physics/CMakeLists.txt:
26512 Imported target "ignition-physics2::ignition-physics2" includes
26513 non-existent path
26514
26515 "/cvmfs/soft.computecanada.ca/easybuild/software/2020/Core/eigen/3.3.7//cvmfs/soft.computecanada.ca/easybuild/software/2020/Core/eigen/3.3.7/include"
26516
26517 in its INTERFACE_INCLUDE_DIRECTORIES. Possible reasons include:
26518
26519 * The path was deleted, renamed, or moved to another location.
26520
26521 * An install or uninstall procedure did not complete successfully.
26522
26523 * The installation package was faulty and references files it does not
26524 provide.I guess I should open a separate issue for this ?
The path should obviously be
/cvmfs/soft.computecanada.ca/easybuild/software/2020/Core/eigen/3.3.7/include
rather than
/cvmfs/soft.computecanada.ca/easybuild/software/2020/Core/eigen/3.3.7//cvmfs/soft.computecanada.ca/easybuild/software/2020/Core/eigen/3.3.7/include
Not sure (yet) how ignition-physics2 gets that separate path....
mboisson
commented
3 years ago Any pointer about how those cmake files are generated ? It obviously detect eigen and writes it in this cmake file, but writes it incorrectly.
$ grep -i eigen /home/mboisson/.local/easybuild/software/2020/avx2/Compiler/gcc9/ignition/citadel/lib64/cmake/ignition-physics2/ignition-physics2-targets.cmake
INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include/ignition/physics2;/cvmfs/soft.computecanada.ca/easybuild/software/2020/Core/eigen/3.3.7//cvmfs/soft.computecanada.ca/easybuild/software/2020/Core/eigen/3.3.7/include"
INTERFACE_SYSTEM_INCLUDE_DIRECTORIES "/cvmfs/soft.computecanada.ca/easybuild/software/2020/Core/eigen/3.3.7//cvmfs/soft.computecanada.ca/easybuild/software/2020/Core/eigen/3.3.7/include"I guess the patch in https://github.com/ignitionrobotics/ign-physics/pull/282 should fix the problem (note that the PR is against ign-physics4, but I guess that probably a similar fix can be applied to ign-physics 2).
traversaro
commented
3 years ago See https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#creating-relocatable-packages for more details on CMake relocatable packages (that I guess it is what is required by easybuild, even if I am not an expert).
mboisson
commented
3 years ago We do not (usually) install in place, indeed. So I guess they need to be relocatable. Thanks for the pointer. I will try the patch (or a similar patch).
traversaro
commented
3 years ago Not sure what is your use case for ign-gazebo, but in that case probably you may be interested in https://github.com/ignitionrobotics/ign-gazebo/issues/626 .
mboisson
commented
3 years ago I am just trying to build all of ignitition-citadel suite. Our user actually asked for ORSF Gazebo 11, and it depends on a lot of the ignition-citadel components, so I figured I would install all of the components, and then build ORSF Gazebo 11 using ignitition-citadel as a dependency. Is that a bad idea ? Should I skip some components ?
mboisson
commented
3 years ago 🤔 , now the configuration passes, but the build fails...
Maybe building gazebo is not such a good idea, but if it does not build, doesn't that mean that other components were not built correctly ?
26509 ignition/msgs/entity.proto: File not found.
26510 performer_affinity.proto:22:1: Import "ignition/msgs/entity.proto" was not found or had errors.
26511 performer_affinity.proto:29:3: "ignition.msgs.Entity" is not defined.
26512 ignition/msgs/header.proto: File not found.
26513 peer_control.proto:22:1: Import "ignition/msgs/header.proto" was not found or had errors.
26514 peer_control.proto:30:3: "ignition.msgs.Header" is not defined.
26515 make[2]: *** [src/msgs/CMakeFiles/ignition-gazebo_private_msgs.dir/build.make:84: src/msgs/performer_affinity.pb.h] Error 1
26516 make[2]: *** Waiting for unfinished jobs....
26517 make[2]: *** [src/msgs/CMakeFiles/ignition-gazebo_private_msgs.dir/build.make:76: src/msgs/peer_control.pb.h] Error 1
26518 ignition/msgs/header.proto: File not found.
26519 peer_info.proto:22:1: Import "ignition/msgs/header.proto" was not found or had errors.
26520 peer_info.proto:28:3: "ignition.msgs.Header" is not defined.
26521 make[2]: *** [src/msgs/CMakeFiles/ignition-gazebo_private_msgs.dir/build.make:68: src/msgs/peer_info.pb.h] Error 1
26522 ignition/msgs/world_stats.proto: File not found.
26523 ignition/msgs/entity.proto: File not found.
26524 performer_affinity.proto:22:1: Import "ignition/msgs/entity.proto" was not found or had errors.
26525 performer_affinity.proto:29:3: "ignition.msgs.Entity" is not defined.
26526 simulation_step.proto:22:1: Import "ignition/msgs/world_stats.proto" was not found or had errors.
26527 simulation_step.proto:23:1: Import "performer_affinity.proto" was not found or had errors.
26528 simulation_step.proto:32:3: "ignition.msgs.WorldStatistics" is not defined.
26529 simulation_step.proto:36:12: "PerformerAffinity" is not defined.Our user actually asked for ORSF Gazebo 11, and it depends on a lot of the
ignition-citadelcomponents, so I figured I would install all of the components, and then build ORSF Gazebo 11 usingignitition-citadelas a dependency. Is that a bad idea ? Should I skip some components ?
It is not a bad idea, but probably it is more work then necessary, as for Gazebo 11 you will not need ignition-gazebo or ignition-physics, that are exactly the one that are giving you problems.
However, I guess we are definitely OT at this point here, so perhaps it could make sense to open an issue in osrf/gazebo repo instead?
mboisson
commented
3 years ago Ok. I will do this.
chapulina
commented
3 years ago build ORSF Gazebo 11 using ignitition-citadel as a dependency.
If it helps, instead of building the entire collection-citadel from source as instructed on our docs, you can just get the Gazebo 11 dependencies from gazebo11.yaml.
I'm trying to build
ign-gazebo3_3.8.0, and I encounter:According to this page https://stackoverflow.com/questions/52533396/cmake-cant-find-protobuf-protobuf-generate-cpp there would be something missing in the
CMakeLists.txt, but even patching it did not resolve the issue.I have
protobuf/3.12.3andcmake/3.16.5Any idea ?
Below is the full log: