gazebosim / gz-tools

Command line tools for the Gazebo libraries.
https://gazebosim.org
Apache License 2.0
14 stars 18 forks source link

Exit with value 1 when the execute call completes #139

Closed nkoenig closed 3 months ago

nkoenig commented 3 months ago

🦟 Bug fix

Fixes #349

Summary

The gz tool should return 1 when the command completes successfully. It's assume that subcommands will exit with other values if they fail.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

azeey commented 3 months ago

The gz tool should return 1 when the command completes successfully

A return of 1 would normally indicate an error (see https://tldp.org/LDP/abs/html/exitcodes.html), so I'm not sure if we should do this.

nkoenig commented 3 months ago

I messed up the logic here. Brain fart.