search

gazebosim / gz-tools

Command line tools for the Gazebo libraries.
https://gazebosim.org
Apache License 2.0
14 stars 18 forks source link

Backport: Fix dll search paths for Ruby on Windows (#140) #141

Closed azeey closed 2 months ago

azeey commented 2 months ago

Backport

Backporting #140

Note to maintainers: Remember to Rebase

azeey commented 2 months ago

@j-rivero Do we not have Jammy ci-pr setup for ign-tools1? It seems like it was a required job, but has been waiting for multiple days.

scpeters commented 2 months ago

@j-rivero Do we not have Jammy ci-pr setup for ign-tools1? It seems like it was a required job, but has been waiting for multiple days.

my reading of the following configuration file is that we have Ubuntu Focal jenkins jobs for citadel, fortress, and garden and Ubuntu Jammy jenkins jobs only for harmonic and upcoming distros

scpeters commented 2 months ago

@j-rivero Do we not have Jammy ci-pr setup for ign-tools1? It seems like it was a required job, but has been waiting for multiple days.

my reading of the following configuration file is that we have Ubuntu Focal jenkins jobs for citadel, fortress, and garden and Ubuntu Jammy jenkins jobs only for harmonic and upcoming distros

I just updated the required job listing for the ign-tools1 branch to require focal and not require jammy

azeey commented 2 months ago

@j-rivero Do we not have Jammy ci-pr setup for ign-tools1? It seems like it was a required job, but has been waiting for multiple days.

my reading of the following configuration file is that we have Ubuntu Focal jenkins jobs for citadel, fortress, and garden and Ubuntu Jammy jenkins jobs only for harmonic and upcoming distros

I just updated the required job listing for the ign-tools1 branch to require focal and not require jammy

Okay, I wasn't sure if the branch requirement was there before we started using gz-collections.yaml, so I thought it might be a bug in the transition.

azeey commented 2 months ago

Argh, I should have Rebase merged this. Sorry :(