search

gazebosim / gz-tools

Command line tools for the Gazebo libraries.
https://gazebosim.org
Apache License 2.0
15 stars 18 forks source link

Add ruby style checker #25

Closed caguero closed 4 years ago

caguero commented 4 years ago

Integrate rubocop as the ruby style checker.

@chapulina, @j-rivero, should we move the rubocop dependency from here to https://github.com/ignition-tooling/action-ignition-ci/blob/master/entrypoint.sh directly?

chapulina commented 4 years ago

Nice!

should we move the rubocop dependency from here to https://github.com/ignition-tooling/action-ignition-ci/blob/master/entrypoint.sh directly?

Since this is something that won't be needed by all packages, I'm leaning towards leaving it here.

chapulina commented 4 years ago

Since this is something that won't be needed by all packages,

Wait, come to think of it, most packages have a cmd<lib>.rb file that could be linted too :smirk: And ign-math has more and more Ruby files too.

So now I think we could use some Ruby linting for most libraries. I guess the difficulty will be to put it in a common place to reduce duplication. Sort of how we have make codecheck on ign-cmake (which wouldn't help ign-tools...).