Open scpeters opened 2 years ago
Hey @scpeters, I tried adding macros to ign-tools
rather thanign-cmake
as discussed here https://github.com/ignitionrobotics/ign-cmake/pull/225. I added the code in Utils.cmake but it's not working. Other macros in Utils.cmake are also not working (some of which are working are also mentioned in ign-cmake (like ign_add_executable)). Could you provide some examples or guidance on how to proceed?
Hey @scpeters, I tried adding macros to
ign-tools
rather thanign-cmake
as discussed here ignitionrobotics/ign-cmake#225. I added the code in Utils.cmake but it's not working. Other macros in Utils.cmake are also not working (some of which are working are also mentioned in ign-cmake (like ign_add_executable)). Could you provide some examples or guidance on how to proceed?
I figured out that you had to install the required cmake file and include it in ignition-config.cmake.in.I have raised a pr and would love for you and @j-rivero to review it.
Sorry for the silence Harsh, I was out some months when this issue/PRs landed. Back to this, seems to me like there was an agreement to move the features to gz-cmake
instead of having it in gz-tools
. May I have the details of that agreement or the reason why we need to put it under gz-cmake
?
Sorry for the silence Harsh, I was out some months when this issue/PRs landed. Back to this, seems to me like there was an agreement to move the features to
gz-cmake
instead of having it ingz-tools
. May I have the details of that agreement or the reason why we need to put it undergz-cmake
?
There was a discussion on this issue during Gazebo weekly meets, and after that, I was instructed to re-move it to gz-cmake.
Hey @j-rivero, any updates on this? I can help if some changes need to be done before merging
Desired behavior
We currently have a lot of repeated boilerplate code in each library that generates the
conf/*.yaml
andcmd*.rb
files. It would be nice to provide some cmake helper functions. We could install that withign-tools
since it is related to this package.For example in ign-transport:
and also in ign-plugin
The helper functions should be able to generate separate files for installation and testing.
Alternatives considered
Implementation suggestion
Additional context