gazebosim / gz-tools

Command line tools for the Gazebo libraries.
https://gazebosim.org
Apache License 2.0
14 stars 18 forks source link

Macros for generating cmd*.rb , conf/*.yaml files #81

Closed harshmahesheka closed 2 years ago

harshmahesheka commented 2 years ago

🎉 New feature

Closes #72

Summary

Added Macros for generating cmd.rb and conf/.yaml files which decreases boilerplate code from repositories.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

harshmahesheka commented 2 years ago

So I've done a cursory pass of the macros and there are some minor knits I've pointed out. The bigger question is have you used these macros anywhere? How can I test that they run correctly? If you'd like you can create forks of the libraries and point me to branches where you are using them.

As a good rule of thumb, always include instructions on how to test your code in the PR description.

I have resolved all the knits and added instructions for testing it with ign-transport.I will try to think of some better names

harshmahesheka commented 2 years ago

As discussed I am closing this pr and opening another one here https://github.com/gazebosim/gz-cmake/pull/270