gazebosim / gz-tools

Command line tools for the Gazebo libraries.
https://gazebosim.org
Apache License 2.0
15 stars 18 forks source link

Remove configure.bat #83

Closed chapulina closed 2 years ago

chapulina commented 2 years ago

🦟 Bug fix

Summary

That file shouldn't be needed anymore. Windows CI says

"DEPRECATED configure.bat file detected. It should be removed from upstream sources"

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

πŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”ΈπŸ”Έ

scpeters commented 2 years ago

actually, we've done this before: https://github.com/ignition-tooling/release-tools/issues/588#issuecomment-989935106

I think we need to restore configure.bat for the sake of gazebo11's windows CI

scpeters commented 2 years ago

actually, we've done this before: ignition-tooling/release-tools#588 (comment)

I think we need to restore configure.bat for the sake of gazebo11's windows CI

Build Status https://build.osrfoundation.org/job/gazebo-ci-gazebo11-windows7-amd64/140/

scpeters commented 2 years ago

actually, we've done this before: ignition-tooling/release-tools#588 (comment)

I think we need to restore configure.bat for the sake of gazebo11's windows CI

84