Open osrf-migration opened 4 years ago
Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).
the ABI breakage was merged forward to ign-transport8
in pull request #419, fixed in ign-transport8
in pull request #425, and merged forward to default in pull request #426
Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).
do we want to change anything on ign-transport7
? the breakage has already been released in 7.2.0 and 7.2.1.
cc @j-rivero
Original comment by Jose Luis Rivero (Bitbucket: Jose Luis Rivero, GitHub: j-rivero).
Ideally we should revert it as soon as possible in a new version. For the unreleased branches please revert the change asap.
Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).
targeting ABI fix to ign-transport7
in pull request #427
Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).
A parameter with a default value was added to
ignition::transport::log::Playback::Start
in pull request #401. It was merged and released in 7.2.0, but we didn't notice the complaints by the ABI checking job:https://build.osrfoundation.org/job/ignition_transport-abichecker-any_to_any-ubuntu_auto-amd64/103/API_5fABI_20report/
https://osrf-migration.github.io/ignition-gh-pages/#!/ignitionrobotics/ign-transport/pull-requests/401/subt-enable-fast-log-playback/diff#comment-129364518
cc @j-rivero