gazebosim / gz-transport

Transport library for component communication based on publication/subscription and service calls.
https://gazebosim.org
Apache License 2.0
29 stars 43 forks source link

ABI broken between 7.1.0 and 7.2.0 #115

Open osrf-migration opened 4 years ago

osrf-migration commented 4 years ago

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


A parameter with a default value was added to ignition::transport::log::Playback::Start in pull request #401. It was merged and released in 7.2.0, but we didn't notice the complaints by the ABI checking job:

cc @j-rivero

osrf-migration commented 4 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


the ABI breakage was merged forward to ign-transport8 in pull request #419, fixed in ign-transport8 in pull request #425, and merged forward to default in pull request #426

osrf-migration commented 4 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


do we want to change anything on ign-transport7? the breakage has already been released in 7.2.0 and 7.2.1.

cc @j-rivero

osrf-migration commented 4 years ago

Original comment by Jose Luis Rivero (Bitbucket: Jose Luis Rivero, GitHub: j-rivero).


Ideally we should revert it as soon as possible in a new version. For the unreleased branches please revert the change asap.

osrf-migration commented 4 years ago

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


targeting ABI fix to ign-transport7 in pull request #427