search

gazebosim / gz-transport

Transport library for component communication based on publication/subscription and service calls.
https://gazebosim.org
Apache License 2.0
29 stars 36 forks source link

Merge gz-transport12 ➡️ main #434

Closed azeey closed 10 months ago

azeey commented 10 months ago

➡️ Forward port

Port gz-transport12 ➡️ main

Branch comparison: https://github.com/gazebosim/gz-transport/compare/main...gz-transport12

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

azeey commented 10 months ago

The ParamCommand test is failing with

/home/jenkins/workspace/gz_transport-ci-pr_any-jammy-amd64/gz-transport/parameters/src/cmd/ParamCommandAPI_TEST.cc:103
Expected: (std::string::npos) != (output.find("gz_msgs.Boolean")), actual: 18446744073709551615 vs 18446744073709551615

I'll try changing to gz.msgs.Boolean. /cc @mjcarroll

azeey commented 10 months ago

For some reason the Jammy Jenkins job wasn't started automatically. Build Status

codecov[bot] commented 10 months ago

Codecov Report

Merging #434 (1300478) into main (d888517) will increase coverage by 0.04%. Report is 3 commits behind head on main. The diff coverage is 100.00%.

:exclamation: Current head 1300478 differs from pull request most recent head 0f6392a. Consider uploading reports for the commit 0f6392a to get more accurate results

@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
+ Coverage   87.75%   87.79%   +0.04%     
==========================================
  Files          59       59              
  Lines        5693     5696       +3     
==========================================
+ Hits         4996     5001       +5     
+ Misses        697      695       -2
Files Changed Coverage Δ
include/gz/transport/Discovery.hh 87.00% <100.00%> (+0.04%) :arrow_up:
python/src/transport/_gz_transport_pybind11.cc 75.00% <100.00%> (+0.15%) :arrow_up:

... and 1 file with indirect coverage changes