gazebosim / gz-transport

Transport library for component communication based on publication/subscription and service calls.
https://gazebosim.org
Apache License 2.0
29 stars 36 forks source link

Fix Docker in Harmonic #440

Closed caguero closed 10 months ago

caguero commented 10 months ago

🦟 Bug fix

Summary

Updates Dockerfile and fixes a minor issue in a tutorial.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 New feature

Closes #

Summary

Test it

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

➡️ Forward port

Port to

Branch comparison: https://github.com/gazebosim//compare/...

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎈 Release

Preparation for <X.Y.Z> release.

Comparison to <x.y.z>: https://github.com/gazebosim//compare/...

Needed by <PR(s)>

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 10 months ago

Codecov Report

Merging #440 (792c208) into gz-transport13 (d92aed2) will decrease coverage by 0.04%. The diff coverage is n/a.

:exclamation: Current head 792c208 differs from pull request most recent head dea1cfd. Consider uploading reports for the commit dea1cfd to get more accurate results

@@                Coverage Diff                 @@
##           gz-transport13     #440      +/-   ##
==================================================
- Coverage           87.76%   87.72%   -0.04%     
==================================================
  Files                  59       59              
  Lines                5696     5696              
==================================================
- Hits                 4999     4997       -2     
- Misses                697      699       +2     

see 1 file with indirect coverage changes

caguero commented 10 months ago

LGTM! Now that we have python bindings, we could add pybind11 to the Dockerfile as well.

Good idea. Added in dea1cfd.