gazebosim / gz-transport

Transport library for component communication based on publication/subscription and service calls.
https://gazebosim.org
Apache License 2.0
29 stars 36 forks source link

Catch execeptions from callbacks since it might cause a crash #443

Closed azeey closed 10 months ago

azeey commented 10 months ago

🦟 Bug fix

Summary

Any exception by a callback might cause a crash in gz-sim (see https://github.com/gazebosim/harmonic_demo/pull/14#discussion_r1334693934), so it's best to catch it here and print a traceback.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 10 months ago

Codecov Report

Merging #443 (6d94adf) into gz-transport13 (d92aed2) will decrease coverage by 0.13%. Report is 1 commits behind head on gz-transport13. The diff coverage is n/a.

:exclamation: Current head 6d94adf differs from pull request most recent head 00d393d. Consider uploading reports for the commit 00d393d to get more accurate results

@@                Coverage Diff                 @@
##           gz-transport13     #443      +/-   ##
==================================================
- Coverage           87.76%   87.64%   -0.13%     
==================================================
  Files                  59       59              
  Lines                5696     5696              
==================================================
- Hits                 4999     4992       -7     
- Misses                697      704       +7     

see 1 file with indirect coverage changes