gazebosim / gz-transport

Transport library for component communication based on publication/subscription and service calls.

https://gazebosim.org

Apache License 2.0

29 stars 36 forks source link

Adds the python bindings tutorial #450

Closed Voldivh closed 8 months ago

Voldivh commented 9 months ago

🎉 New feature

Summary

This PR creates a new tutorial page with all the relevant information regarding the python API created for gz-transport in https://github.com/gazebosim/gz-transport/pull/411.

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

ahcorde commented 9 months ago

friendly ping @Voldivh

Voldivh commented 9 months ago

friendly ping @Voldivh

The CI issues should have been solved by the last commit. Could you take a look @ahcorde?

ahcorde commented 9 months ago

@Voldivh there are still some unresolved comments

Voldivh commented 9 months ago

@Voldivh there are still some unresolved comments

Oh I completely missed that comment, sorry. Take a look now.

codecov[bot] commented 9 months ago

Codecov Report

Merging #450 (0b273c1) into gz-transport13 (b012e82) will increase coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head 0b273c1 differs from pull request most recent head 46e050b. Consider uploading reports for the commit 46e050b to get more accurate results

@@                Coverage Diff                 @@
##           gz-transport13     #450      +/-   ##
==================================================
+ Coverage           87.78%   87.79%   +0.01%     
==================================================
  Files                  59       59              
  Lines                5696     5696              
==================================================
+ Hits                 5000     5001       +1     
+ Misses                696      695       -1

Files	Coverage Δ
python/src/transport/_gz_transport_pybind11.cc	`75.00% <ø> (ø)`

... and 2 files with indirect coverage changes

ahcorde commented 9 months ago

Thank you @Voldivh

ahcorde commented 8 months ago

friendly ping @azeey