gazebosim / gz-transport

Transport library for component communication based on publication/subscription and service calls.
https://gazebosim.org
Apache License 2.0
29 stars 36 forks source link

Adds the third level commands for the log #451

Closed Voldivh closed 8 months ago

Voldivh commented 9 months ago

🎉 New feature

This PR addresses the issue https://github.com/gazebosim/gz-tools/issues/1 regarding adding the third-level flags for log command.

Summary

Test it

$ . install/share/bash-completion/completions/ign
$ ign log r<tab> 

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 9 months ago

Codecov Report

Merging #451 (8bf5016) into ign-transport8 (b3a8182) will increase coverage by 4.19%. The diff coverage is 80.28%.

:exclamation: Current head 8bf5016 differs from pull request most recent head 3134c5f. Consider uploading reports for the commit 3134c5f to get more accurate results

@@                Coverage Diff                 @@
##           ign-transport8     #451      +/-   ##
==================================================
+ Coverage           83.56%   87.76%   +4.19%     
==================================================
  Files                  51       59       +8     
  Lines                5039     5696     +657     
==================================================
+ Hits                 4211     4999     +788     
+ Misses                828      697     -131     
Files Coverage Δ
include/gz/transport/AdvertiseOptions.hh 100.00% <ø> (ø)
include/gz/transport/Clock.hh 100.00% <ø> (ø)
include/gz/transport/HandlerStorage.hh 100.00% <100.00%> (ø)
include/gz/transport/Publisher.hh 100.00% <ø> (ø)
include/gz/transport/RepHandler.hh 86.04% <ø> (+0.68%) :arrow_up:
include/gz/transport/ReqHandler.hh 81.65% <ø> (+1.06%) :arrow_up:
include/gz/transport/SubscriptionHandler.hh 85.45% <ø> (+0.54%) :arrow_up:
include/gz/transport/TopicStatistics.hh 100.00% <ø> (ø)
include/gz/transport/TopicStorage.hh 100.00% <100.00%> (ø)
include/gz/transport/Uuid.hh 100.00% <ø> (ø)
... and 36 more

... and 7 files with indirect coverage changes

azeey commented 9 months ago

@j-rivero ign_transport-ci-pr_any-bionic-amd64 job is saying /bin/bash: ./scripts/jenkins-scripts/docker/ign_transport-compilation.bash: No such file or directory. Is this a recent change?

j-rivero commented 9 months ago

@j-rivero ign_transport-ci-pr_any-bionic-amd64 job is saying /bin/bash: ./scripts/jenkins-scripts/docker/ign_transport-compilation.bash: No such file or directory. Is this a recent change?

ugh, this is a bug introduced probably during the move the yaml file. Should be fixed by https://github.com/gazebo-tooling/release-tools/pull/1043.

j-rivero commented 9 months ago

@osrf-jenkins run tests

Voldivh commented 8 months ago

Friendly ping @azeey

azeey commented 8 months ago

Works for me. I'll go ahead and merge.