Closed mjcarroll closed 8 months ago
Merging #453 (e2c0729) into gz-transport13 (b012e82) will increase coverage by
0.04%
. The diff coverage is100.00%
.:exclamation: Current head e2c0729 differs from pull request most recent head 257cf7c. Consider uploading reports for the commit 257cf7c to get more accurate results
@@ Coverage Diff @@
## gz-transport13 #453 +/- ##
==================================================
+ Coverage 87.78% 87.82% +0.04%
==================================================
Files 59 59
Lines 5696 5699 +3
==================================================
+ Hits 5000 5005 +5
+ Misses 696 694 -2
Files | Coverage Δ | |
---|---|---|
src/Node.cc | 91.80% <100.00%> (+0.68%) |
:arrow_up: |
I'm pretty sure this is going to be problematic ABI/API-wise.
@osrf-jenkins run tests
@osrf-jenkins run tests please
I don't think this breaks ABI. My understanding is that the constructor with the default argument and the new constructor with a single argument will have the same symbol name, so this PR is essentially only adding the default constructor from an ABI perspective.
I think this is actually what we intended to do with the
Node
constructor.The
explicit
keyword makes using the default constructor a little strange in combination withImplPtr
.For example:
Produces the compiler error:
The other option is to update each Implementation class to explicitly pass the NodeOptions such as follows, but this seems excessive in my mind.