gazebosim / gz-transport

Transport library for component communication based on publication/subscription and service calls.
https://gazebosim.org
Apache License 2.0
29 stars 42 forks source link

Fix issue #468 #470

Closed caguero closed 8 months ago

caguero commented 8 months ago

🦟 Bug fix

Fixes #468

Summary

As described in issue #468, the case of a Request() before an Advertise() when both calls are within the same process wasn't considered. This patch makes it work as in the case where requester and responser are in different processes (which was already working).

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (764a04b) 87.80% compared to head (ec324d2) 87.83%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## gz-transport13 #470 +/- ## ================================================== + Coverage 87.80% 87.83% +0.02% ================================================== Files 59 59 Lines 5699 5704 +5 ================================================== + Hits 5004 5010 +6 + Misses 695 694 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.