Closed scpeters closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
764a04b
) 87.80% compared to head (505537f
) 87.94%. Report is 1 commits behind head on gz-transport13.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
windows failed to find python development, as its search for gz-msgs
found a version of python that may have derailed the later search. I'm going to try moving the python search logic before the search for gz-msgs
I believe this find logic is fixed as of https://github.com/gazebosim/gz-transport/pull/472/commits/505537f5a99fe6422629f31390d0bb1fb9fdaa83
I used ci_matching_branch/
to run some CI jobs to reproduce the failure with gz-transport13
built from source and then to confirm the fix with this branch
gz-transport13
(using https://github.com/osrf/homebrew-simulation/commit/568ec0dd0560c959d1d6ef12283133f6078bda92)
🦟 Bug fix
Motivated by https://github.com/gazebosim/gz-sim/issues/2249.
Summary
While testing the use of
-DPython3_EXECUTABLE=$(which python3)
to aid in finding the right version of python3 on macOS (see https://github.com/osrf/homebrew-simulation/pull/2543), I ran into some cmake configuration issues when testing locally (the bottle build seems to be progressing fine though). I was able to fix my local build by consolidating the logic for finding python3 by removing the use of gz-cmake'sGzPython
in favor of a single call tofind_package(Python3)
. This fixes settingPython3_EXECUTABLE
to specify which python version to use and is needed on macOS.As an aside, I'm going to suggest that we deprecate
GzPython
onmain
since it's better and simpler to just find python directly with modern versions of cmake.Check the diff without whitespace to see a simpler version of the changes without the indentation.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.