search

gazebosim / gz-transport

Transport library for component communication based on publication/subscription and service calls.
https://gazebosim.org
Apache License 2.0
29 stars 36 forks source link

Merge gz-transport13 ➡️ main #479

Closed scpeters closed 3 months ago

scpeters commented 5 months ago

➡️ Forward port

Port gz-transport13 ➡️ main

Branch comparison: https://github.com/gazebosim/gz-transport/compare/main...gz-transport13

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

scpeters commented 5 months ago

@osrf-jenkins run tests please

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.64%. Comparing base (94b335f) to head (9aaa434).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #479 +/- ## ========================================== - Coverage 87.80% 87.64% -0.17% ========================================== Files 59 59 Lines 5699 5704 +5 ========================================== - Hits 5004 4999 -5 - Misses 695 705 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

scpeters commented 5 months ago

looks like CI is happy now, aside from coverage

iche033 commented 3 months ago

@caguero is the playback.ReplayStep test failure on windows expected / flaky?

caguero commented 3 months ago

@caguero is the playback.ReplayStep test failure on windows expected / flaky?

I think it's flaky, I've seen it fail before.