search

gazebosim / gz-transport

Transport library for component communication based on publication/subscription and service calls.
https://gazebosim.org
Apache License 2.0
29 stars 36 forks source link

Re-enable tests of bash completion functions for gz #481

Closed mjcarroll closed 4 months ago

mjcarroll commented 4 months ago

Follow-up from #478

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eac2e69) 87.69% compared to head (014e40e) 87.69%. Report is 2 commits behind head on gz-transport13.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## gz-transport13 #481 +/- ## =============================================== Coverage 87.69% 87.69% =============================================== Files 59 59 Lines 5704 5704 =============================================== Hits 5002 5002 Misses 702 702 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mjcarroll commented 4 months ago

homebrew looks unhappy

I'm not sure these tests worked on homebrew before, I will limit them to just Linux.

mjcarroll commented 4 months ago

Trying something slightly different and starting with /usr/bin/bash and falling back to /bin/bash if that isn't available. The subprocess class doesn't do anything with the PATH environment variable, you have to have the full and complete path to the binary in question.

mjcarroll commented 4 months ago

@scpeters did a brief inspection for me on macOS and things didn't seem to work, likely because of some security mechanism of the operating system. Since the value of this test is mainly in checking the flags for consistency and keeping them in sync between the completion scripts and the executables, running cross-platform isn't really necessary here.