Closed caguero closed 6 months ago
@osrf-jenkins run tests please
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.83%. Comparing base (
eac2e69
) to head (7b1e4de
). Report is 8 commits behind head on gz-transport13.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think you need to merge from gz-transport13
to fix the ABI checker issues. This repo doesn't require having the branch up-to-date to merge, but we can enable it if we want.
🦟 Bug fix
Fixes #97 and #474
Summary
This patch makes it possible to request a no input service request from the command line. Before, it was possible passing
--reqtype gz.msgs.Empty
but always adding the--req 'unused: true'
How to test it?
You can compile the examples, and then:
Launch the no-input responser:
Request the service using the "old" way:
Use the new no-input request and verify that you still get a reply:
Note that both requests should reach the responser and you should get a reply on the requester terminal:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.