gazebosim / gz-transport

Transport library for component communication based on publication/subscription and service calls.
https://gazebosim.org
Apache License 2.0
29 stars 36 forks source link

Delete copy ctor and copy-assignment for log::Batch #501

Closed mbeards closed 1 month ago

mbeards commented 1 month ago

🦟 Bug fix

Summary

Fixes rule-of-five violation and reduces flakiness of playback tests.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

mbeards commented 1 month ago

do you mind to sign the commit ?

Looks like the error is on the previous commit https://github.com/gazebosim/gz-transport/pull/501/commits/f043ddb910105fcc661950fec5a5afebe85a1225 already on main?

azeey commented 1 month ago

It looks like the "Validate package.xml" Action fails because the base branch of this PR was changed and that workflow hasn't been forward ported to main. I'll go ahead and merge.