gazebosim / gz-transport

Transport library for component communication based on publication/subscription and service calls.

https://gazebosim.org

Apache License 2.0

29 stars 36 forks source link

Add frequency to topic CLI. #503

Closed bperseghetti closed 2 weeks ago

bperseghetti commented 1 month ago

🦟 Bug fix

Fixes #

Summary

Adds frequency sampling to a topic through gz topic CLI.

Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

bperseghetti commented 1 month ago

Thanks for the contribution! In general, I would recommend using gz::math::SignalStats for all of this. I don't see examples or tutorials but here's a test that shows how to use it.

Is there an example of this functions performance vs a minimal operations oriented implementation like I provided? Mostly saying this because we use gz-transport on some very very very low compute systems to enable HIL, so if I can cut any extra ops anywhere, I prefer that. Especially something that can be tightly time bounded such as message transports.

azeey commented 2 weeks ago

There are changes in the base branch, gz-transport13 that haven't been merged. That's why the ABI checker is failing. Can you merge and push?

bperseghetti commented 2 weeks ago

There are changes in the base branch, gz-transport13 that haven't been merged. That's why the ABI checker is failing. Can you merge and push?

rebased and pushed.