search

gazebosim / gz-transport

Transport library for component communication based on publication/subscription and service calls.
https://gazebosim.org
Apache License 2.0
29 stars 42 forks source link

Disable playback.ReplayStep for windows (#517) #546

Closed claraberendsen closed 4 days ago

claraberendsen commented 5 days ago

➡️ Forward port

Port gz-transport13 to gz-transport14

Branch comparison: https://github.com/gazebosim/gz-transport/compare/gz-transport14...claraberendsen:claraberendsen/13_to_14_2024-10-01

Follow up of https://github.com/gazebosim/gz-transport/pull/517, https://github.com/gazebosim/gz-transport/pull/518, https://github.com/gazebosim/gz-transport/pull/521, #522

Disables https://github.com/gazebosim/gz-transport/issues/195

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

claraberendsen commented 5 days ago

@azeey it seems on the move to gz-transport14 we missed the commit that disabled playback.ReplayStep.

claraberendsen commented 4 days ago

@azeey thanks for the comments, I changed the title to match the expectations. I cannot merge this since I don't have permission so I will let that to the team to do the proper action of rebase and merge since it is a cherry pick. I can open a new PR that uses git merge if you prefer.