gazebosim / gz-utils

Classes and functions for robot applications
https://gazebosim.org/
Apache License 2.0
6 stars 10 forks source link

Use spdlog_vendor in package.xml #146

Closed azeey closed 1 week ago

azeey commented 1 week ago

🦟 Bug fix

Summary

spdlog is not being properly found on ROS windows builds. Example: https://ci.ros2.org/view/nightly/job/nightly_win_rel/3158/cmake/new/

Per @clalancette's recommendation, this patch changes the package.xml entry to spdlog_vendor.

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

azeey commented 1 week ago

Yup, you're right. This should be done in gz_utils_vendor. I've updated the generation script https://github.com/gazebo-tooling/gz_vendor/pull/9 and I've approved https://github.com/gazebo-release/gz_utils_vendor/pull/6