gazebosim / ros_gz

Integration between ROS (1 and 2) and Gazebo simulation
https://gazebosim.org
Apache License 2.0
233 stars 135 forks source link

Support `<gazebo_ros>` in `package.xml` exports #492

Closed azeey closed 6 months ago

azeey commented 8 months ago

🎉 New feature

Summary

This copies the implementation from gazebo_ros_paths.py to provide a way for packages to set resource paths from package.xml.

e.g.  <export>
          <gazebo_ros gazebo_model_path="${prefix}/models"/>
          <gazebo_ros gazebo_media_path="${prefix}/models"/>
      </export>

The value of gazebo_model_path and gazebo_media_path is appended to GZ_SIM_RESOURCE_PATH The value of plugin_path appended to GZ_SIM_SYSTEM_PLUGIN_PATH.

This will make transition from Gazebo Classic easier.

Test it

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

azeey commented 8 months ago

it might be worth it to add a tutorial about this or small doc about this.

Good point!

Do you have plans to forward port this to Iron and Rolling?

Yes, I'll cherry-pick this to Iron and Rolling. I was going to start on Rolling first, but I wanted to make sure the humble branch got the IGN_* variables modified as well.

DLu commented 7 months ago

Are we waiting on the Tutorial to get this merged?

I have a URDF/Gazebo tutorial waiting to be merged and there is a section ("Side note: Configuring meshes") that covers this area. The tutorial is written for for Gazebo Classique, but as linked above, I'm trying to get the Gazebo New Coke version to work too.

azeey commented 7 months ago

@ahcorde , @DLu I've added a section to the README that explains how to use this. Let me know your thoughts. This could be expanded into a full tutorial on gazebosim.org/docs.

DLu commented 7 months ago

Tip the hat

ahcorde commented 6 months ago

@azeey do you have any plan to forward port this to iron and rolling?

rakeshv24 commented 3 months ago

@azeey is this feature included in the jazzy release yet?

azeey commented 3 months ago

Ah, this fell through the cracks. I've started the forward port process: https://github.com/gazebosim/ros_gz/pull/564

rakeshv24 commented 3 months ago

Thanks!