`expand_gz_topic_names` parameter does not work - Githubissues

gazebosim / ros_gz

Integration between ROS (1 and 2) and Gazebo simulation

https://gazebosim.org

Apache License 2.0

250 stars 138 forks source link

`expand_gz_topic_names` parameter does not work #529

Closed elkuno213 closed 5 months ago

elkuno213 commented 7 months ago

Environment

OS Version: Ubuntu 22.04
Source or binary build? binary build by apt, version iron

Description

Expected behavior: when expand_gz_topic_names is true, the namespace on Gazebo should be changed.
Actual behavior: the namespace does not change and this parameter cannot be found via ros2 param list.

Steps to reproduce

Follow the Example 6.
Run this command:

ros2 run ros_gz_bridge parameter_bridge chatter@std_msgs/msg/String@ignition.msgs.StringMsg \
  --ros-args -p expand_gz_topic_names:=true -r __ns:=/demo

In other terminal, run this command:
```
ign topic --list 
# Output: /chatter
```
The topic is still /chatter, not /demo/chatter as expected.

Run other command to check whether the parameter is existing:

ros2 param list | grep expand_gz_topic_names
# Output: nothing found

This code snippet shows that expand_gz_topic_names only works when config_file is given.

Output

azeey commented 7 months ago

expand_gz_topic_names was added recently in https://github.com/gazebosim/ros_gz/pull/512 and ported to iron in https://github.com/gazebosim/ros_gz/pull/516. It has not been released yet (see https://github.com/gazebosim/ros_gz/blob/iron/ros_gz_bridge/CHANGELOG.rst). @ahcorde can you make a 0.254.1 release?

ahcorde commented 7 months ago

I made releases for Humble and Iron