gazebosim / sdformat

Simulation Description Format (SDFormat) parser and description files.
http://sdformat.org
Apache License 2.0
166 stars 92 forks source link

Use relative install paths in CMake #1387

Closed azeey closed 6 months ago

azeey commented 6 months ago

🦟 Bug fix

Summary

This fixes an error when building https://github.com/gazebo-release/sdformat_vendor/ in the ROS buildfarm where CMAKE_STAGING_PREFIX is used

Similar to https://github.com/gazebosim/gz-tools/pull/137

Checklist

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.42%. Comparing base (ff9b3ad) to head (a038b59). Report is 2 commits behind head on sdf14.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## sdf14 #1387 +/- ## ======================================= Coverage 92.42% 92.42% ======================================= Files 134 134 Lines 17751 17751 ======================================= Hits 16406 16406 Misses 1345 1345 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

scpeters commented 6 months ago

brew CI failure looks unrelated, I believe caused by update to pybind11:

fix in https://github.com/gazebosim/sdformat/pull/1389