Closed scpeters closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.42%. Comparing base (
ff9b3ad
) to head (e960bed
). Report is 5 commits behind head on sdf14.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🦟 Bug fix
Adds more expectations to a unit test
Summary
While investigating how to implement a suggestion added in a comment in https://github.com/gazebosim/sdformat/commit/d3532946bc64fef713b30fbb1ab21a33603bf9dd, I noticed that the
UNIT_Param_TEST
has many calls tobool Param::Get
andbool Param::Set
without checking the return value. This adds expectations on the return value of those function calls, which will aid in addressing the aforementioned comment with a behavior change PR onmain
.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.